sanity checks on message types during rekey#793
Merged
ejohnstown merged 8 commits intowolfSSL:masterfrom Oct 6, 2025
Merged
Conversation
Contributor
Author
|
Retest this please Jenkins |
There was a problem hiding this comment.
Pull Request Overview
This PR adds sanity checks on message types during rekey operations by introducing new macros and updating error handling logic across various modules. Key changes include:
- Addition of WS_MSG_SEND and WS_MSG_RECV macros in wolfssh/internal.h.
- Refactored error handling logic in several functions (e.g., replacing explicit WS_WANT_READ/WS_WANT_WRITE checks with NoticeError calls) and updated rekeying condition handling.
- Updates in helper functions and example applications to incorporate the new rekeying checks.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| wolfssh/internal.h | Added new macros WS_MSG_SEND and WS_MSG_RECV with an accompanying comment. |
| src/wolfsftp.c | Modified error handling using NoticeError, improving rekey error management. |
| src/ssh.c | Added rekeying checks in stream read/send and channel read functions. |
| src/internal.c | Updated IsMessageAllowed signature to accept a new state parameter and added keying checks. |
| examples/sftpclient/sftpclient.c | Incorporated rekey state recovery logic in the autopilot command loop. |
| examples/client/client.c | Adjusted rekeying error handling in input and peer reading functions. |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
dgarske
approved these changes
Oct 6, 2025
ejohnstown
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZD18338